Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Feature: miscellaneous chain icon changes #5718

Closed
wants to merge 1 commit into from

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Dec 13, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the ChainIcon component and related functionalities, improving test coverage, and implementing a new ChainActiveDot component for better visual representation of active chains.

Detailed summary

  • Added ChainActiveDot component for indicating active chains.
  • Refactored ChainIcon to utilize fetchChainIcon and getQueryKeys functions.
  • Improved error handling in fetchChainIcon.
  • Enhanced test cases for fetchChainIcon and getQueryKeys.
  • Introduced fallbackChainIcon for missing chain icons.
  • Removed legacy ActiveDot styling from ChainIcon.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: 4aebca2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 3:34am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 3:34am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 3:34am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 3:34am

Copy link

graphite-app bot commented Dec 13, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 13, 2024
import { StyledDiv } from "../design-system/elements.js";

/**
* The greet dot that is placed at the corner of the chain icon -
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in comment: "greet dot" should be "green dot" since this describes the green indicator dot shown at the corner of chain icons to indicate active status.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 665 ms (+14.46% 🔺) 1.6 s
thirdweb (cjs) 110.78 KB (0%) 2.3 s (0%) 1.6 s (+10.36% 🔺) 3.9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 292 ms (+570.49% 🔺) 404 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 87 ms (+142.22% 🔺) 97 ms
thirdweb/react (minimal + tree-shaking) 19.03 KB (0%) 381 ms (0%) 303 ms (+313.67% 🔺) 684 ms

Copy link
Member

@joaquim-verges joaquim-verges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aspect ratio is wrong?

CleanShot 2024-12-14 at 14.35.51@2x.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants